Add colour customisation to layout editor #29936
Open
+329
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
requested changes
Sep 20, 2024
peppy
requested changes
Sep 24, 2024
| @@ -114,6 +118,7 @@ protected override void Update() | |||
| base.Update(); | |||
| content.Height = bar.Height + bar_height + info.Height; | |||
| graphContainer.Height = bar.Height; | |||
| Colour = AccentColour.Value; | |||
There was a problem hiding this comment.
I question why this needs to be in update. Let's use the bindable as a bindable instead yeah?
There was a problem hiding this comment.
jesus. not sure how i'd missed that.
There was a problem hiding this comment.
removed in 9f4e48d. also found one more when i was looking at that again.
| @@ -114,6 +118,8 @@ protected override void Update() | |||
|
|
|||
| if (!Precision.AlmostEquals(Height, newHeight, 5f)) | |||
| content.Height = newHeight; | |||
|
|
|||
| Colour = AccentColour.Value; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to change colour for:
AdjustingColour.mp4
I also implemented this to
FontAdjustableSkinComponentbecause it makes sense but I'm not too sure.I don't think there's design for button for adjusting colour, so I came up with my own.